Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ground_segmentation): add missing parameters #231

Merged
merged 11 commits into from
Apr 17, 2024

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Apr 5, 2024

tier4/autoware.universe@debe198 でデフォルト値が削除されたパラメータを追加 & 一部パラメータ名の変更に対応

1222-takeshi and others added 4 commits April 5, 2024 02:01
@Autumn60 Autumn60 requested a review from 1222-takeshi April 5, 2024 05:19
@Autumn60 Autumn60 marked this pull request as draft April 5, 2024 05:31
Autumn60 added 3 commits April 5, 2024 14:49
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
@Autumn60 Autumn60 marked this pull request as ready for review April 5, 2024 10:46
Autumn60 and others added 4 commits April 6, 2024 10:25
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1222-takeshi 1222-takeshi merged commit f481d69 into add-XT32-model Apr 17, 2024
7 of 8 checks passed
@1222-takeshi 1222-takeshi deleted the chore/add-missing-params branch April 17, 2024 03:26
1222-takeshi added a commit that referenced this pull request Apr 17, 2024
* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>
1222-takeshi added a commit that referenced this pull request May 2, 2024
* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>
Autumn60 added a commit that referenced this pull request Sep 17, 2024
* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>
Autumn60 added a commit that referenced this pull request Sep 17, 2024
* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>
Autumn60 added a commit that referenced this pull request Sep 27, 2024
* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>
Autumn60 pushed a commit that referenced this pull request Sep 27, 2024
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix(velodyne_node_container): fix param load failure

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix(diagnostic_aggregator): update sensor kit param (#22) (#23)

* fix(diagnostic_aggregator): Modified aggregator confinguration to V1'

* fix path on diagnostic aggregator

fix: add vehicle_velocity_converter.launch (#146)

fix: add vehicle_velocity_converter.launch to aip_x1_1_launch

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add use_awsim option and add gnss imu

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add GNSS

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: update for upstream

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add use_awsim option

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: change topic name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add node alive monitoring

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add gnss

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: update ground_segmentation param

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: remove use_awsim option

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add cropbox filter

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add diag of gyro_bias_validator

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: update for upstream

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: comment out for avoid no diag stale

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add gnss.launch for x1_1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: use pointcloud_container

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix: change topic name for ground segmentation

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(aip_x1_launch): rename some topics

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(aip_x1, aip_x1_1): use interpolate

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(velodyne_node_container): use distortion_corrector

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(ground_segmentation): change crop parameter

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(obstacle_segmentation): relax ground_segmentation threshold

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore(ground_segmentation): change parameter name (#229)

* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

chore(ground_segmentation): add missing parameters (#231)

* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>

feat: use nebula driver for aip_x1_1 sensor configuration (#235)

* feat: use nebula driver for aip_x1_1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* chore: remove comment out

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* chore: remove unnecessary changes

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

chore: remove aip_x1 and rename aip_x1_1 to aip_x1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: rename aip_x1_1 to aip_x1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: remove unused file and fix bug

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

ci(pre-commit): autofix

fix: diag list

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Autumn60 pushed a commit that referenced this pull request Oct 8, 2024
author 1222-takeshi <m.takeshi1995@gmail.com> 1684121183 +0900
committer Autumn60 <harada.akiro@gmail.com> 1728374152 +0900

feat: update aip_x1 to use XT32

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix(velodyne_node_container): fix param load failure

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix(diagnostic_aggregator): update sensor kit param (#22) (#23)

* fix(diagnostic_aggregator): Modified aggregator confinguration to V1'

* fix path on diagnostic aggregator

fix: add vehicle_velocity_converter.launch (#146)

fix: add vehicle_velocity_converter.launch to aip_x1_1_launch

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add use_awsim option and add gnss imu

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add GNSS

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: update for upstream

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add use_awsim option

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: change topic name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add node alive monitoring

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add gnss

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: update ground_segmentation param

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: remove use_awsim option

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add cropbox filter

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add diag of gyro_bias_validator

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: update for upstream

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: comment out for avoid no diag stale

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add gnss.launch for x1_1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: use pointcloud_container

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix: change topic name for ground segmentation

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(aip_x1_launch): rename some topics

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(aip_x1, aip_x1_1): use interpolate

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(velodyne_node_container): use distortion_corrector

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(ground_segmentation): change crop parameter

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(obstacle_segmentation): relax ground_segmentation threshold

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore(ground_segmentation): change parameter name (#229)

* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

chore(ground_segmentation): add missing parameters (#231)

* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>

feat: use nebula driver for aip_x1_1 sensor configuration (#235)

* feat: use nebula driver for aip_x1_1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* chore: remove comment out

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* chore: remove unnecessary changes

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

chore: remove aip_x1 and rename aip_x1_1 to aip_x1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: rename aip_x1_1 to aip_x1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: remove unused file and fix bug

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

ci(pre-commit): autofix

fix: diag list

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix cancat lidar topics

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Autumn60 pushed a commit that referenced this pull request Oct 8, 2024
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix(velodyne_node_container): fix param load failure

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix(diagnostic_aggregator): update sensor kit param (#22) (#23)

* fix(diagnostic_aggregator): Modified aggregator confinguration to V1'

* fix path on diagnostic aggregator

fix: add vehicle_velocity_converter.launch (#146)

fix: add vehicle_velocity_converter.launch to aip_x1_1_launch

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add use_awsim option and add gnss imu

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add GNSS

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: update for upstream

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add use_awsim option

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: change topic name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add node alive monitoring

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add gnss

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: update ground_segmentation param

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: remove use_awsim option

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add cropbox filter

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add diag of gyro_bias_validator

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: update for upstream

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: comment out for avoid no diag stale

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add gnss.launch for x1_1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: use pointcloud_container

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix: change topic name for ground segmentation

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(aip_x1_launch): rename some topics

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(aip_x1, aip_x1_1): use interpolate

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(velodyne_node_container): use distortion_corrector

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(ground_segmentation): change crop parameter

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(obstacle_segmentation): relax ground_segmentation threshold

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore(ground_segmentation): change parameter name (#229)

* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

chore(ground_segmentation): add missing parameters (#231)

* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>

feat: use nebula driver for aip_x1_1 sensor configuration (#235)

* feat: use nebula driver for aip_x1_1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* chore: remove comment out

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* chore: remove unnecessary changes

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

chore: remove aip_x1 and rename aip_x1_1 to aip_x1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: rename aip_x1_1 to aip_x1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: remove unused file and fix bug

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

ci(pre-commit): autofix

fix: diag list

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix cancat lidar topics

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Autumn60 added a commit that referenced this pull request Oct 15, 2024
* feat: update aip_x1 to use XT32

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix(velodyne_node_container): fix param load failure

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix(diagnostic_aggregator): update sensor kit param (#22) (#23)

* fix(diagnostic_aggregator): Modified aggregator confinguration to V1'

* fix path on diagnostic aggregator

fix: add vehicle_velocity_converter.launch (#146)

fix: add vehicle_velocity_converter.launch to aip_x1_1_launch

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add use_awsim option and add gnss imu

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add GNSS

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: update for upstream

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add use_awsim option

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: change topic name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add node alive monitoring

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add gnss

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: update ground_segmentation param

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: remove use_awsim option

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add cropbox filter

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add diag of gyro_bias_validator

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: update for upstream

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: comment out for avoid no diag stale

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: add gnss.launch for x1_1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat: use pointcloud_container

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix: change topic name for ground segmentation

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(aip_x1_launch): rename some topics

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(aip_x1, aip_x1_1): use interpolate

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(velodyne_node_container): use distortion_corrector

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(ground_segmentation): change crop parameter

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

feat(obstacle_segmentation): relax ground_segmentation threshold

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore(ground_segmentation): change parameter name (#229)

* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

chore(ground_segmentation): add missing parameters (#231)

* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>

feat: use nebula driver for aip_x1_1 sensor configuration (#235)

* feat: use nebula driver for aip_x1_1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* chore: remove comment out

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* chore: remove unnecessary changes

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

chore: remove aip_x1 and rename aip_x1_1 to aip_x1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: rename aip_x1_1 to aip_x1

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

chore: remove unused file and fix bug

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

ci(pre-commit): autofix

fix: diag list

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

fix cancat lidar topics

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* feat: add input_offset parameter to pointcloud preprocessor launch

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* feat: nebula_hw_monitor is not started except when simulation is running

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* chore(blockage_diag): update param for aip_x1_launch (#268)

* add enable_blockage_diag argument to lidar.launch.xml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

---------

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix: change container name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* chore: add prefix for rosdep

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* fix: config for awsim (#289)

* delete unnecessary arg passing

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* fix gnss_poser param

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* Adjust gnss launching condition

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* fix invalid tag usage

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

* ci(pre-commit): autofix

---------

Signed-off-by: Autumn60 <harada.akiro@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore: replace use_awsim to use_gnss (#292)

replace use_awsim to use_gnss

Signed-off-by: Autumn60 <harada.akiro@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Signed-off-by: Autumn60 <harada.akiro@gmail.com>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: asa-naki <akihisa.nagata@tier4.jp>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kimurariku pushed a commit that referenced this pull request Feb 26, 2025
* chore(ground_segmentation): change parameter name

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* ci(pre-commit): autofix

* Add missing params to ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box params in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Fix crop_box param in ground_segmentation.param.yaml

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Revert crop_box params

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* Add cropbox param calc to ground_segmentation.launch.py

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>

* chore(ground_segmentation): change margin_max_z for cropbox

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>

---------

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Co-authored-by: 1222-takeshi <m.takeshi1995@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Autumn60 <akiro.harada@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants